Repository navigation
ci(tester): check translations completeness on tags and release branches only - #529
Merged
Merged
Conversation
…RICT is true The check fails whenever a feature branch adds a self.tr() string, which is expected before the translation step. Skip it by default and let the CI enable it for releases. AI-Level: 7 AI-Model: Claude Sonnet 5.5 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUNZAW4orsNs4vNDGpAAFx
…hes only Run the tests on tags and release/* branches, and set DICOGIS_I18N_STRICT there (including for pull requests whose source branch is release/*). Also trigger on changes to dicogis/ui/i18n/*. AI-Level: 7 AI-Model: Claude Sonnet 5.5 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUNZAW4orsNs4vNDGpAAFx
…eness check AI-Level: 7 AI-Model: Claude Sonnet 5.5 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUNZAW4orsNs4vNDGpAAFx
github-actions
Bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 78.26% 78.23% -0.03%
==========================================
Files 54 54
Lines 3469 3469
Branches 435 435
==========================================
- Hits 2715 2714 -1
Misses 633 633
- Partials 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 of 11 tasks
Guts
added a commit
that referenced
this pull request
Nov 3, 2026
## Description The documentation builder fails in the "Install GDAL binaries" step: `runs-on: ubuntu-latest` now resolves to Ubuntu 26.04 (resolute), and the `ubuntugis/ubuntugis-unstable` PPA has no Release file for it, so `apt update` ends with a 404 (seen on #529, whose docs change triggered the workflow; the last run on `master`, on 2026-10-18, was green). This pins the job to `ubuntu-24.04`, the runner already used by the other workflows adding this PPA (`tester.yml`, `builder_releaser.yml`, `tester_udata_publish.yml`) and where the same install commands succeed. Other `ubuntu-latest` jobs (`docker_builder.yml`, the release job of `builder_releaser.yml`, the PR labeler) do not add the PPA and are left untouched. ## Related issue(s) Seen on #529. ## Type of change - [ ] Bug fix (`fix/…` branch) - [ ] New feature or enhancement (`feature/…` branch) - [ ] Documentation (`docs/…` branch or `*.md`/`docs/**` changes) - [ ] Packaging / build (`packaging/…` branch or `builder/**` changes) - [x] Tooling / CI-CD (`tooling/…` branch or `.github/**` changes) - [ ] Tests only (`tests/**` changes) ## Checklist - [ ] I have read the [Contributing Guidelines](/CONTRIBUTING.md) - [ ] `pre-commit run --all-files` passes locally - [ ] I have added or updated tests covering my changes - [ ] I have updated the documentation where relevant - [ ] `pytest` passes locally One-line workflow change: the check is the "Documentation Builder" run of this very pull request, as the workflow file is in its path filter. ## AI/LLM disclosure - Level: 7 (human specced, bots coded) - Model: Claude Sonnet 5.5 - Session: https://claude.ai/code/session_01CUNZAW4orsNs4vNDGpAAFx --- _Generated by [Claude Code](https://claude.ai/code/session_01CUNZAW4orsNs4vNDGpAAFx)_
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The translations completeness check (
test_every_widget_string_is_translatedintests/test_ui_i18n.py) ran on every push and pull request, and failed as soon as a branch added aself.tr()string, which is expected until the translation step. It is now only enforced on tags andrelease/*branches.tests/test_ui_i18n.py: the completeness test is skipped unless theDICOGIS_I18N_STRICTenvironment variable is true (default: skipped, with the reason displayed). The.qmfreshness test is unchanged and still always runs..github/workflows/tester.yml: the workflow now also runs on tags andrelease/*branches, and setsDICOGIS_I18N_STRICTfor a tag, arelease/*branch, or a pull request whose source branch isrelease/*. Changes todicogis/ui/i18n/*also trigger it on branches, otherwise a push touching only.ts/.qmfiles would not run anything. Path filters are not evaluated for pushes of tags (GitHub docs).docs/development/translation.md: documents the variable and how to run the strict check locally:DICOGIS_I18N_STRICT=1 pytest tests/test_ui_i18n.py.Heads-up: with the strict mode on, the check currently fails on
masterfor one string without ES translation ("Fund, support"), so it has to be translated before the next release.Related issue(s)
None.
Type of change
fix/…branch)feature/…branch)docs/…branch or*.md/docs/**changes)packaging/…branch orbuilder/**changes)tooling/…branch or.github/**changes)tests/**changes)Checklist
pre-commit run --all-filespasses locallypytestpasses locallyOnly
ruff checkandruff format --checkwere run on the changed test file, andpytest tests/test_ui_i18n.pywas run with and withoutDICOGIS_I18N_STRICT(skipped by default, failing on the missing ES string when enabled). The fullpre-commitandpytestruns remain to be done by a human, as does the first run of the workflow on a tag or arelease/*branch.AI/LLM disclosure
Generated by Claude Code